asan: properly run asan test #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was meant to crash by heap-buffer-overflow. However, the test only checked if the program crashed, not what caused it. Because there are no program arguments (yet) it would always crash through nullptr deref, making the test falsely pass.
|
I only changed the commit message in the last few force pushes, so the latest pass on the CI is representative of the changes |
yuri91
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was meant to crash by heap-buffer-overflow. However, the test only checked if the program crashed, not what caused it. Because there are no program arguments (yet) it would always crash through nullptr deref, making the test falsely pass.